enhance(frontend): サインイン画面の改善

[kakkokari-gtyih]

What

• enhance: require captcha for signin #14655 を取り込み
• MkSignin周りを全面的に改修
• 一部足りてなさそうなエラーメッセージを追加
• 二要素認証系のプロパティを外部に露出しないように

Why

Close #14655

Additional info (optional)

Checklist

• Read the contribution guide
• Test working in a local environment
• (If needed) Add story of storybook
• (If needed) Update CHANGELOG.md
• (If possible) Add tests

[github-actions]

このPRによるapi.jsonの差分

差分はこちら

--- base
+++ head
@@ -77005,18 +77005,6 @@
               "private"
             ]
           },
-          "twoFactorEnabled": {
-            "type": "boolean",
-            "default": false
-          },
-          "usePasswordLessLogin": {
-            "type": "boolean",
-            "default": false
-          },
-          "securityKeys": {
-            "type": "boolean",
-            "default": false
-          },
           "roles": {
             "type": "array",
             "items": {
@@ -77039,6 +77027,15 @@
           "moderationNote": {
             "type": "string"
           },
+          "twoFactorEnabled": {
+            "type": "boolean"
+          },
+          "usePasswordLessLogin": {
+            "type": "boolean"
+          },
+          "securityKeys": {
+            "type": "boolean"
+          },
           "isFollowing": {
             "type": "boolean"
           },
@@ -77103,9 +77100,6 @@
           "publicReactions",
           "followingVisibility",
           "followersVisibility",
-          "twoFactorEnabled",
-          "usePasswordLessLogin",
-          "securityKeys",
           "roles",
           "memo"
         ]
@@ -77882,6 +77876,18 @@
             "type": "object",
             "$ref": "#/components/schemas/RolePolicies"
           },
+          "twoFactorEnabled": {
+            "type": "boolean",
+            "default": false
+          },
+          "usePasswordLessLogin": {
+            "type": "boolean",
+            "default": false
+          },
+          "securityKeys": {
+            "type": "boolean",
+            "default": false
+          },
           "email": {
             "type": [
               "string",
@@ -77954,7 +77960,10 @@
           "emailNotificationTypes",
           "achievements",
           "loggedInDays",
-          "policies"
+          "policies",
+          "twoFactorEnabled",
+          "usePasswordLessLogin",
+          "securityKeys"
         ]
       },
       "UserDetailedNotMe": {

Get diff files from Workflow Page

[codecov]

Codecov Report

Attention: Patch coverage is 5.11364% with 1002 lines in your changes missing coverage. Please review.

Project coverage is 41.29%. Comparing base (e344650) to head (e962140).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
packages/frontend/src/components/MkSignin.vue	0.00%	329 Missing ⚠️
...ackages/frontend/src/components/MkSignin.input.vue	0.00%	205 Missing and 1 partial ⚠️
...ages/frontend/src/components/MkSignin.password.vue	0.00%	180 Missing and 1 partial ⚠️
...kages/frontend/src/components/MkSignin.passkey.vue	0.00%	91 Missing and 1 partial ⚠️
packages/frontend/src/components/MkSignin.totp.vue	0.00%	73 Missing and 1 partial ⚠️
...ackages/frontend/src/components/MkSigninDialog.vue	0.00%	65 Missing ⚠️
...ackages/backend/src/server/api/SigninApiService.ts	27.02%	54 Missing ⚠️
...ges/backend/src/core/entities/UserEntityService.ts	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #14658      +/-   ##
===========================================
+ Coverage    39.69%   41.29%   +1.59%     
===========================================
  Files         1544     1552       +8     
  Lines       193859   200240    +6381     
  Branches      3592     3615      +23     
===========================================
+ Hits         76950    82682    +5732     
- Misses      116313   116957     +644     
- Partials       596      601       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[syuilo]

パスワード入力しても「続ける」が活性化しないかも

[syuilo]

2faのトークン入力とパスワード入力は一緒の画面で良い気もした

[syuilo]

🎨

[kakkokari-gtyih]

パスワード入力しても「続ける」が活性化しないかも

Captcha周りのチェックがなにかおかしいかも

[syuilo]

2faのトークン入力とパスワード入力は一緒の画面で良い気もした

YOSASOUであれば実装お願いしたい

[kakkokari-gtyih]

#14655 のすべてが取り込まれているわけではないっぽい？

develop取り込んだので実質全部取り込んでるはず

[syuilo]

ヘッダーの区切り要るかしら

[kakkokari-gtyih]

スクロールが発生するときにちょっと境界線が見えにくい気はする（ただし好みの問題なので全然消しても問題ない）

[syuilo]

スクロールした時だけ表示されるのが理想ではあるわね

[kakkokari-gtyih]

(Off-topic) Chromaticが落ちているのはMkAbuseReportのStoryを確認するなどの対応が必要そう

[kakkokari-gtyih]

ボーダー消した

[syuilo]

headerはbodyと一体化させたいわね

[syuilo]

見た目上

[kakkokari-gtyih]

細かい調整はお願いしてもいいかしら

[syuilo]

👍🏿