Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): update and re-enable Bull Dashboard #14648

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

zyoshoka
Copy link
Contributor

What

Bull Dashboard は #14594 で無効化されていましたが Fastify 5 対応のリリースが出ましたので使えるように戻します。

Why

ないと不便ですので

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.75%. Comparing base (15f2e14) to head (c351a10).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/backend/src/server/web/ClientServerService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14648      +/-   ##
===========================================
- Coverage    39.75%   39.75%   -0.01%     
===========================================
  Files         1544     1544              
  Lines       193604   193618      +14     
  Branches      2561     3537     +976     
===========================================
- Hits         76972    76970       -2     
+ Misses      116069   116053      -16     
- Partials       563      595      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Thank you for sending us a great Pull Request! 👍
Please regenerate misskey-js type definitions! 🙏

example:

pnpm run build-misskey-js-with-types

Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@syuilo syuilo merged commit 1184436 into misskey-dev:develop Sep 29, 2024
32 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 29, 2024

🙏🏻

@zyoshoka zyoshoka deleted the update-bull-board branch September 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants