Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): cwでも絵文字メニューを開けるように #14647

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 29, 2024

What

絵文字をクリックしてリアクションとかコピーとかができるやつをCWでも使えるように

Why

本文とCW、両方で使えたほうがよい

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 19.43%. Comparing base (15f2e14) to head (cf80529).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14647       +/-   ##
============================================
- Coverage    39.75%   19.43%   -20.33%     
============================================
  Files         1544      715      -829     
  Lines       193604   101377    -92227     
  Branches      2561      987     -1574     
============================================
- Hits         76972    19703    -57269     
+ Misses      116069    81128    -34941     
+ Partials       563      546       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 088707c into misskey-dev:develop Sep 29, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 29, 2024

👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the fix-cw-emojimenu branch September 29, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants