fix(frontend): mCaptchaを使用していてもbotプロテクションに関する警告が消えないのを修正 #14390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14390 +/- ##
============================================
- Coverage 39.81% 20.25% -19.57%
============================================
Files 1545 723 -822
Lines 190495 100283 -90212
Branches 3551 1049 -2502
============================================
- Hits 75839 20308 -55531
+ Misses 114063 79434 -34629
+ Partials 593 541 -52 ☔ View full report in Codecov by Sentry. |
syuilo
reviewed
Aug 11, 2024
| if (currentPage.value?.route.name == null && !narrow.value) { | ||
| router.push('/admin/overview'); | ||
| } | ||
| }); |
There was a problem hiding this comment.
マウント時のリダイレクトだけで十分なため（実際、設定ページの方はそうなっている）
|
🙏🏻 |
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Aug 19, 2024
…#14390) * fix(frontend): mCaptchaを使用していてもbotプロテクションに関する警告が消えないのを修正 * Update Changelog * refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Fix #14372
Additional info (optional)
Checklist