Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip chromatic / storybook CI for pull requests targets master #14377

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

anatawa12
Copy link
Member

What

ChromaticのCIをmasterを対象とするPRで実行しないことで develop branch で二回実行されてしまうのを避けます。

Why

Chromaticのmonthly limitの無駄使いになると思われる

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12 anatawa12 marked this pull request as ready for review August 8, 2024 10:44
@kakkokari-gtyih kakkokari-gtyih added this to the v2024.8.0 milestone Aug 9, 2024
@syuilo syuilo merged commit 1532d5f into misskey-dev:develop Aug 10, 2024
10 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 10, 2024

🙏🏻

@anatawa12 anatawa12 deleted the skip-chromatic-for-release-pr branch August 10, 2024 05:45
@zyoshoka
Copy link
Contributor

これ結局直ってない気がします…

@anatawa12
Copy link
Member Author

トリガーがpull request targetなのでこの変更がmasterに入らないと効力を持たない気がします

@zyoshoka
Copy link
Contributor

あーその通りですね。失礼しました🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants