Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): getApTypeでエラーを投げないように #14361

Merged
merged 8 commits into from
Aug 11, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Aug 4, 2024

What

  • getApTypeでタイプの特定ができなかった場合はnullを返すように
  • 関連する処理の修正

Why

Fix #14239

Additional info (optional)

こういうことであってる?

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 4, 2024
Copy link
Contributor

github-actions bot commented Aug 4, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 39.91%. Comparing base (0aaf74e) to head (9991606).

Files Patch % Lines
packages/backend/src/core/activitypub/type.ts 69.56% 7 Missing ⚠️
...ckend/src/core/activitypub/models/ApNoteService.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14361      +/-   ##
===========================================
+ Coverage    38.88%   39.91%   +1.03%     
===========================================
  Files         1545     1545              
  Lines       190490   190505      +15     
  Branches      2409     3503    +1094     
===========================================
+ Hits         74072    76044    +1972     
+ Misses      115857   113870    -1987     
- Partials       561      591      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.8.0 milestone Aug 7, 2024
@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo
Copy link
Member

syuilo commented Aug 11, 2024

コメントとかでエラーにしない理由を残しておいた方が良さそう
(そうしないと将来のリファクタとかでエラーを投げる形式に変えるかもしれない)

@kakkokari-gtyih
Copy link
Contributor Author

コメントとかでエラーにしない理由を残しておいた方が良さそう (そうしないと将来のリファクタとかでエラーを投げる形式に変えるかもしれない)

done

@syuilo syuilo merged commit 93fc06d into misskey-dev:develop Aug 11, 2024
26 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 11, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-14239 branch August 11, 2024 07:26
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
* fix(backend): getApTypeでエラーを投げないように

* Update Changelog

* Update Changelog

* Update type.ts

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getApType()cannot detect typeエラーになる場合をvoidで返すようにしたい
2 participants