Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): InstanceEntityService.packMany に me が渡っていないのを修正 #14360

Conversation

kakkokari-gtyih
Copy link
Contributor

What

packManyではモデレーションノートが出力されなかったのでその修正

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

warriordog and others added 3 commits August 4, 2024 13:07
(cherry picked from commit 858ba188768017764c61c4a5591bdf2524a850e7)
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 4, 2024
Copy link
Contributor

github-actions bot commented Aug 4, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 39.91%. Comparing base (61eec93) to head (0728720).
Report is 260 commits behind head on develop.

Files Patch % Lines
...backend/src/core/entities/InstanceEntityService.ts 0.00% 2 Missing ⚠️
...ckend/src/server/api/endpoints/federation/stats.ts 0.00% 2 Missing ⚠️
...d/src/server/api/endpoints/federation/instances.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14360       +/-   ##
============================================
- Coverage    66.21%   39.91%   -26.31%     
============================================
  Files          990     1544      +554     
  Lines       117137   190357    +73220     
  Branches      4489     2690     -1799     
============================================
- Hits         77568    75972     -1596     
- Misses       39538   113824    +74286     
- Partials        31      561      +530     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 0aaf74e into misskey-dev:develop Aug 11, 2024
26 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 11, 2024

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the fix-instanceentity-include-me-in-packmany branch August 11, 2024 02:30
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
…y-dev#14360)

* fix: pass current user into `InstanceEntityService.packMany`

(cherry picked from commit 858ba188768017764c61c4a5591bdf2524a850e7)

* Update Changelog

* origin

* Update Changelog

---------

Co-authored-by: Hazel K <acomputerdog@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants