-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Eio 0.7 #952
Update for Eio 0.7 #952
Conversation
Was cfbbe49 needed as well? |
Not strictly necessary but nice to have, I think. Perhaps cherry pick it? |
What's the advantage of cfbbe49? The new code is a little longer. Is it faster? I would have thought that allocating the Failure exception wouldn't be any quicker than allocating an empty string, and installing an exception handler on the normal path would be a little slower? |
I haven't done any bench-marking to verify if using exception handling is faster than allocation. However, my reasoning for the change is that exception handler in OCaml is very fast (since it is a register in a stack) and the overhead of a handler is that of a function call. Secondly, the code before was allocating an extra string in every call to |
I suggest merging this as-is, as it fixes the compiler warning. The other change can happen in a separate PR if it turns out to be useful. |
…p-curl, cohttp-eio, cohttp-lwt-jsoo, cohttp-lwt-unix, cohttp-lwt, cohttp-mirage, cohttp-server-lwt-unix, cohttp-top, cohttp and http (6.0.0~alpha1) CHANGES: - cohttp,cohttp-async server: correctly close broken streams (reported by Stéphane Glondu, fix by samhot and anuragsoni) - cohttp-eio: remove unused code from tests to work with Eio 0.8 (talex5 mirage/ocaml-cohttp#967) - Upgrade dune to v3.0 (bikallem mirage/ocaml-cohttp#947) - cohttp-eio: allow client to optionally configure request pipelining (bikallem mirage/ocaml-cohttp#949) - cohttp-eio: update to Eio 0.7 (talex5 mirage/ocaml-cohttp#952) - cohttp-eio: update examples to use eio 0.7 primitives (bikallem mirage/ocaml-cohttp#957) - cohttp-eio: generate Date header in responses (bikallem mirage/ocaml-cohttp#955) - cohttp-eio: further improve Cohttp_eio.Client ergonomics (bikallem #?) - cohttp-eio: server api improvements (bikallem mirage/ocaml-cohttp#962)
…p-curl, cohttp-eio, cohttp-lwt-jsoo, cohttp-lwt-unix, cohttp-lwt, cohttp-mirage, cohttp-server-lwt-unix, cohttp-top, cohttp and http (6.0.0~alpha1) CHANGES: - cohttp,cohttp-async server: correctly close broken streams (reported by Stéphane Glondu, fix by samhot and anuragsoni) - cohttp-eio: remove unused code from tests to work with Eio 0.8 (talex5 mirage/ocaml-cohttp#967) - Upgrade dune to v3.0 (bikallem mirage/ocaml-cohttp#947) - cohttp-eio: allow client to optionally configure request pipelining (bikallem mirage/ocaml-cohttp#949) - cohttp-eio: update to Eio 0.7 (talex5 mirage/ocaml-cohttp#952) - cohttp-eio: update examples to use eio 0.7 primitives (bikallem mirage/ocaml-cohttp#957) - cohttp-eio: generate Date header in responses (bikallem mirage/ocaml-cohttp#955) - cohttp-eio: further improve Cohttp_eio.Client ergonomics (bikallem #?) - cohttp-eio: server api improvements (bikallem mirage/ocaml-cohttp#962)
…p-curl, cohttp-eio, cohttp-lwt-jsoo, cohttp-lwt-unix, cohttp-lwt, cohttp-mirage, cohttp-server-lwt-unix, cohttp-top, cohttp and http (6.0.0~alpha1) CHANGES: - cohttp,cohttp-async server: correctly close broken streams (reported by Stéphane Glondu, fix by samhot and anuragsoni) - cohttp-eio: remove unused code from tests to work with Eio 0.8 (talex5 mirage/ocaml-cohttp#967) - Upgrade dune to v3.0 (bikallem mirage/ocaml-cohttp#947) - cohttp-eio: allow client to optionally configure request pipelining (bikallem mirage/ocaml-cohttp#949) - cohttp-eio: update to Eio 0.7 (talex5 mirage/ocaml-cohttp#952) - cohttp-eio: update examples to use eio 0.7 primitives (bikallem mirage/ocaml-cohttp#957) - cohttp-eio: generate Date header in responses (bikallem mirage/ocaml-cohttp#955) - cohttp-eio: further improve Cohttp_eio.Client ergonomics (bikallem #?) - cohttp-eio: server api improvements (bikallem mirage/ocaml-cohttp#962)
(once ocaml/opam-repository#22619 is merged)
/cc @bikallem