Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cohttp-eio: Match body encoding with headers. #1012

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

mefyl
Copy link
Contributor

@mefyl mefyl commented Jan 1, 2024

Based on #1011.

@mseri
Copy link
Collaborator

mseri commented Jan 3, 2024

Sorry can you rebase on master?

@mseri
Copy link
Collaborator

mseri commented Jan 3, 2024

And thanks!

@mseri
Copy link
Collaborator

mseri commented Jan 5, 2024

Thanks

@mseri
Copy link
Collaborator

mseri commented Jan 5, 2024

I plan to make the release as soon as I figure out why I get the weird failure: #1010
But I don't have time to look again into it before a couple of weeks

@mseri mseri merged commit 537c9cd into mirage:master Jan 5, 2024
17 of 19 checks passed
@mefyl mefyl deleted the fix/eio-body-encoding branch January 5, 2024 11:47
@mefyl
Copy link
Contributor Author

mefyl commented Jan 5, 2024

I plan to make the release as soon as I figure out why I get the weird failure: #1010 But I don't have time to look again into it before a couple of weeks

I think #1013 fixes it.

mseri added a commit to mseri/opam-repository that referenced this pull request Jan 5, 2024
CHANGES:

- cohttp-eio: Don't blow up Server on client disconnections. (mefyl mirage/ocaml-cohttp#1011)
- cohttp-eio: Match body encoding with headers. (mefyl mirage/ocaml-cohttp#1012)
- cohttp-lwt: Preserve extended `Server.S.IO` signature. (mefyl mirage/ocaml-cohttp#1013)
mseri added a commit to mseri/opam-repository that referenced this pull request Jan 5, 2024
CHANGES:

- cohttp-eio: Don't blow up Server on client disconnections. (mefyl mirage/ocaml-cohttp#1011)
- cohttp-eio: Match body encoding with headers. (mefyl mirage/ocaml-cohttp#1012)
- cohttp-lwt: Preserve extended `Server.S.IO` signature. (mefyl mirage/ocaml-cohttp#1013)
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
CHANGES:

- cohttp-eio: Don't blow up Server on client disconnections. (mefyl mirage/ocaml-cohttp#1011)
- cohttp-eio: Match body encoding with headers. (mefyl mirage/ocaml-cohttp#1012)
- cohttp-lwt: Preserve extended `Server.S.IO` signature. (mefyl mirage/ocaml-cohttp#1013)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants