Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings triggered by Dune 3 #360

Merged
merged 6 commits into from
Nov 3, 2022
Merged

Fix warnings triggered by Dune 3 #360

merged 6 commits into from
Nov 3, 2022

Conversation

MisterDA
Copy link
Collaborator

No description provided.

@MisterDA MisterDA force-pushed the dune-3 branch 4 times, most recently from 5b6742d to 18692bf Compare November 2, 2022 15:40
- checkout@v3
- setup-node@v3
- test with OCaml 4.14, don't runtest 4.11.
Copy link
Member

@TheLortex TheLortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG™

One minor comment about the documentation

src/alcotest-engine/pp_intf.ml Show resolved Hide resolved
src/alcotest-engine/pp_intf.ml Show resolved Hide resolved
@TheLortex TheLortex merged commit e2d5ddf into mirage:main Nov 3, 2022
@MisterDA MisterDA deleted the dune-3 branch November 3, 2022 14:32
samoht added a commit to samoht/opam-repository that referenced this pull request Feb 24, 2023
…d alcotest-async (1.7.0)

CHANGES:

- compile with MSVC (mirage/alcotest#369, @jonahbeckfordm review by @TheLortex
  and @MisterDA)

- Allow skipping a test case from inside the test case (mirage/alcotest#368, @apeschar)

- Fix compilation on bytecode architectures (mirage/alcotest#335, @glondu)

- Get `alcotest_stubs.c` to compile with MSVC (mirage/alcotest#369, @jonahbeckford)

- Try automatically reporting the location of calls to Alcotest.check.
  (mirage/alcotest#366, @MisterDA, review by @TheLortex)

- Detect that Alcotest is running in CI and change output accordingly.
  (mirage/alcotest#364, @MisterDA)

- Upgrade to `dune >= 3.0`. (mirage/alcotest#360, @MisterDA)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants