Fix the processing of test filter ranges to match the documentation #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some context, the switch from I think this was a good rationale, but in the time since then we haven't ended up implementing that feature. Personally, I find |
The documentation of the `test` subcommand gives an example of an integer range using the `-` delimiter, when the implementation actually uses `..`. This regression was introduced by cb9cf43, which switched from `-` to `..` internally. This commit takes the most liberal approach of supporting both syntaxes (and documents them appropriately).
Ngoguey42
approved these changes
May 26, 2021
Comment on lines
+49
to
+55
| let rec aux f acc = function | ||
| | [] -> rev acc | ||
| | x :: l -> | ||
| let xs = f x in | ||
| (aux [@tailcall]) f (rev_append xs acc) l | ||
| in | ||
| aux f [] l |
There was a problem hiding this comment.
Any reason you are passing f to aux?
There was a problem hiding this comment.
This is just me over-optimising out of habit. ocamlopt w/o flambda doesn't do lambda lifting, so if you don't string f through the calls to aux then you need to allocate a closure to store it (which is slower).
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Oct 9, 2021
…and alcotest-lwt (1.5.0) CHANGES: - Make Alcotest compatible with `js_of_ocaml.3.11.0`. Users can depend on the new virtual `alcotest-js` Opam library to pick up the right `js_of_ocaml` version automatically. (mirage/alcotest#326 mirage/alcotest#328, @hhugo @smorimoto) - Record exception backtraces during test suite runs by default. This behaviour can be disabled by passing `~record_backtrace:false` to `Alcotest.run`. (mirage/alcotest#317, @craigfe) - Generate shorter unique identifiers for test runs (8-character alphanumeric, rather than a full 128-bit UUID). (mirage/alcotest#304, @craigfe) - Change `Alcotest.{char,string}` pretty-printers to use OCaml syntax on assertion failures (i.e. wrap with quotes and escape control characters). (mirage/alcotest#318, @craigfe) - Fix process for getting the width of attached terminals on MacOS. Previously, a terminal width of 80 columns was assumed. (mirage/alcotest#325, @craigfe) - Fix parsing of test filter ranges to allow '-' separators (e.g. `test alpha 1-4`), as advertised in the manpage. The previously-used '..' separator is also supported. (mirage/alcotest#312, @craigfe) - Introduce an `Alcotest.V1` module that aliases the existing `Alcotest` API and provides a stability guarantee over major version changes. Similar versioned aliases also exist for the backends: `Alcotest_{async,lwt}.V1`. (mirage/alcotest#306, @craigfe) - Change the `~filter` argument to `Alcotest.run` to be a predicate over tests. (mirage/alcotest#305, @craigfe) - Renamed / removed some less frequently used modules used by the test backends: - `Alcotest.Unix` -> `Alcotest.Unix_platform` - `Alcotest_engine.{Cli,Core,Test}` -> `Alcotest_engine.V1.{Cli,Core,Test}` - `Alcotest.{Cli,Core}` are now gone. Use `Alcotest_engine.V1.{Cli,Core}.Make (Alcotest.Unix_platform)` instead. (mirage/alcotest#306 mirage/alcotest#309, @craigfe) - Avoid exporting `list_tests` in the main test APIs (`Alcotest{,_lwt,_async}`). Use `Alcotest_engine` directly if you want this function. (mirage/alcotest#310, @craigfe)
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Oct 9, 2021
…and alcotest-lwt (1.5.0) CHANGES: - Make Alcotest compatible with `js_of_ocaml.3.11.0`. Users can depend on the new virtual `alcotest-js` Opam library to pick up the right `js_of_ocaml` version automatically. (mirage/alcotest#326 mirage/alcotest#328, @hhugo @smorimoto) - Record exception backtraces during test suite runs by default. This behaviour can be disabled by passing `~record_backtrace:false` to `Alcotest.run`. (mirage/alcotest#317, @craigfe) - Generate shorter unique identifiers for test runs (8-character alphanumeric, rather than a full 128-bit UUID). (mirage/alcotest#304, @craigfe) - Change `Alcotest.{char,string}` pretty-printers to use OCaml syntax on assertion failures (i.e. wrap with quotes and escape control characters). (mirage/alcotest#318, @craigfe) - Fix process for getting the width of attached terminals on MacOS. Previously, a terminal width of 80 columns was assumed. (mirage/alcotest#325, @craigfe) - Fix parsing of test filter ranges to allow '-' separators (e.g. `test alpha 1-4`), as advertised in the manpage. The previously-used '..' separator is also supported. (mirage/alcotest#312, @craigfe) - Introduce an `Alcotest.V1` module that aliases the existing `Alcotest` API and provides a stability guarantee over major version changes. Similar versioned aliases also exist for the backends: `Alcotest_{async,lwt}.V1`. (mirage/alcotest#306, @craigfe) - Change the `~filter` argument to `Alcotest.run` to be a predicate over tests. (mirage/alcotest#305, @craigfe) - Renamed / removed some less frequently used modules used by the test backends: - `Alcotest.Unix` -> `Alcotest.Unix_platform` - `Alcotest_engine.{Cli,Core,Test}` -> `Alcotest_engine.V1.{Cli,Core,Test}` - `Alcotest.{Cli,Core}` are now gone. Use `Alcotest_engine.V1.{Cli,Core}.Make (Alcotest.Unix_platform)` instead. (mirage/alcotest#306 mirage/alcotest#309, @craigfe) - Avoid exporting `list_tests` in the main test APIs (`Alcotest{,_lwt,_async}`). Use `Alcotest_engine` directly if you want this function. (mirage/alcotest#310, @craigfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of the
testsubcommand gives an example of an integer range using the-delimiter, when the implementation actually uses... This regression was introduced by cb9cf43, which switched from-to..internally.This PR takes the most liberal approach of supporting both syntaxes (and documents them appropriately).
CC @samoht.