Use Unix.gettimeofday rather than Unix.time #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We print the duration of test suites to millisecond precision, so we should be using a time source with at least that precision.
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Feb 16, 2021
…lwt (1.3.0) CHANGES: - Add `Alcotest.triple` for testing 3-tuples. (mirage/alcotest#288, @sheepduke) - Correctly report test suite duration with millisecond precision. (mirage/alcotest#286, @craigfe) - Improve pretty-printing of results to consider the terminal width, fixing several display issues due to line wrapping in small terminals. (mirage/alcotest#282, @craigfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We print the duration of test suites to millisecond precision, so we should be using a time source with at least that precision.
It'd be more correct to use
mtime, but this doesn't yet support Windows.