Allow period character to appear unescaped in test names #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfe
force-pushed
the
dont-escape-period
branch
from
f5f60e1
to
a3c531f
Compare
samoht
approved these changes
Jul 13, 2020
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Jul 15, 2020
…age (1.2.1) CHANGES: - Surround pretty-printed diffs with quotes to make trailing whitespace more obvious. (mirage/alcotest#261, @craigfe) - Allow `.` characters to appear unescaped in symlinks and test directories. (mirage/alcotest#259, @craigfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
.as a separator quite frequently in test and suite names, forinstance to refer to findlib names like
index.unix. AFAIK, this character issafe to use in filesystems, so we might as well allow it.