Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unimplemented commands and arguments #368

Merged
merged 5 commits into from
Oct 16, 2022
Merged

Removed unimplemented commands and arguments #368

merged 5 commits into from
Oct 16, 2022

Conversation

EthanBnntt
Copy link
Contributor

Fixes #356

miraclx
miraclx requested changes Oct 12, 2022
View reviewed changes
Copy link
Owner

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through this. How about we just comment these out instead of removing them outright?

@EthanBnntt
Copy link
Contributor Author

I commented out the unimplemented commands and arguments.

miraclx
miraclx reviewed Oct 13, 2022
View reviewed changes
Copy link
Owner

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's fix the lint issues. Run eslint --fix . locally.

@EthanBnntt
Copy link
Contributor Author

I formatted the file.

miraclx
miraclx approved these changes Oct 16, 2022
View reviewed changes
Copy link
Owner

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miraclx miraclx merged commit 4c32f6e into miraclx:master Oct 16, 2022
@miraclx miraclx mentioned this pull request Dec 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miraclx miraclx miraclx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide unimplemented features
2 participants
@EthanBnntt @miraclx