Combine Provider.Keydown and Provider.Keyup into Provider.Keyboard
#663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We spoke about this briefly on Discord, and I was going to write up an issue but figured I may as well just contribute the change since it was relatively easy.
Background info:
It would be nice to have keyboard providers be more consistent with other providers, particularly
Provider.Mouse. At the moment, keyboard events are split into two providers, one fordownsand one forups.This PR combines the providers into a single Provider, called
Provider.Keyboardwhich has bothdownsandups, which is a bit more predictable.I also added some test utilities to
Test.Htmlmodule in order to properly test these changes.Test.Html.triggerKeyDown(context : Context, selector : String, key : String)Test.Html.triggerKeyUp(context : Context, selector : String, key : String)