Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service-worker "fetching" issue #539

Merged
merged 17 commits into from
Apr 5, 2022
Merged

Fix service-worker "fetching" issue #539

merged 17 commits into from
Apr 5, 2022

Conversation

Eternahl
Copy link
Contributor

@Eternahl Eternahl commented Mar 15, 2022 •
edited
Loading

Issue #370

@Eternahl Eternahl changed the title Fix issue #370 Fix service-worker "fetching" issue Mar 15, 2022
@Eternahl
Copy link
Contributor Author

Eternahl commented Mar 28, 2022 •
edited
Loading

I don't think there's anything I can do about the failure of this "checks"
At the moment, it looks like it's just an authentication issue

Downloading Crystal build from https://dl.circleci.com/private/output/job/6ff8e112-da7b-4833-ba05-38428295f826/artifacts/0/dist_packages/crystal-1.4.0-dev-1-darwin-universal.tar.gz
Error: Error: Unexpected HTTP response: 401

@gdotdesign gdotdesign requested a review from Sija April 1, 2022 06:31
@gdotdesign gdotdesign added this to the 0.16.0 milestone Apr 1, 2022
Sija
Sija reviewed Apr 1, 2022
View reviewed changes
spec/sw_compilers/routes Outdated Show resolved Hide resolved
src/builder.cr Outdated Show resolved Hide resolved
src/builder.cr Outdated Show resolved Hide resolved
src/utils/service_worker.cr Outdated Show resolved Hide resolved
src/utils/service_worker.ecr Outdated Show resolved Hide resolved
@Sija Sija added the enhancement New feature or request label Apr 1, 2022
@Sija Sija linked an issue Apr 1, 2022 that may be closed by this pull request
Incorrect fetching from service-worker #370
Closed
Eternahl and others added 5 commits April 4, 2022 09:06
@Eternahl @Sija
Update spec/sw_compilers/routes
c609f24 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@Eternahl @Sija
Update src/builder.cr
5c9b9f2 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@Eternahl @Sija
Update src/utils/service_worker.cr
d5968cf 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@Eternahl @Sija
Update src/utils/service_worker.ecr
75217c2 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@Eternahl @Sija
Update src/builder.cr
9590878 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Sija
Sija reviewed Apr 4, 2022
View reviewed changes
src/builder.cr Outdated Show resolved Hide resolved
Sija
Sija reviewed Apr 4, 2022
View reviewed changes
src/utils/service_worker.cr Outdated Show resolved Hide resolved
@Eternahl @Sija
Update src/utils/service_worker.cr
8d765c2 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
gdotdesign
gdotdesign reviewed Apr 4, 2022
View reviewed changes
src/builder.cr Outdated Show resolved Hide resolved
src/assets/sw-utils.js Show resolved Hide resolved
@gdotdesign
Copy link
Member

I tested it using your branch, and it works well 👍 Apart from the custom runtime issue LGTM 🙏

@Eternahl @Sija
Update src/builder.cr
bf58702 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Sija
Sija requested changes Apr 4, 2022
View reviewed changes
Copy link
Member

@Sija Sija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #539 (comment)

src/builder.cr Outdated Show resolved Hide resolved
src/builder.cr Outdated Show resolved Hide resolved
src/builder.cr Outdated Show resolved Hide resolved
Eternahl and others added 3 commits April 5, 2022 10:29
@Eternahl @Sija
Update src/builder.cr
c81f2cb 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@Eternahl @Sija
Update src/builder.cr
a24ef66 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@Eternahl @Sija
Update src/builder.cr
afc59de 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@Eternahl Eternahl requested a review from Sija April 5, 2022 10:24
@gdotdesign gdotdesign merged commit b7ae455 into mint-lang:master Apr 5, 2022
@gdotdesign
Copy link
Member

Thank you @Eternahl 🙏

@Eternahl Eternahl deleted the fix-issue-370 branch April 5, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdotdesign gdotdesign gdotdesign approved these changes

@Sija Sija Awaiting requested review from Sija

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

Incorrect fetching from service-worker
3 participants
@Eternahl @gdotdesign @Sija