Update Clipboard.set to restore clobbered global state #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Clipboard.set` method clobbers the global state, removing focus from the current active element and removing all content selections. This commit remembers the initial active element and selection(s), restoring them after the clipboard operation is complete. It also updates `Clipboard.set` to return its argument for convenient chaining.
ryanprior
force-pushed
the
hygenic-clipboard-set
branch
from
054ea4a
to
0538908
Compare
gdotdesign
reviewed
Dec 5, 2021
core/source/Clipboard.mint
Outdated
| textarea.remove() | ||
| })() | ||
| ` | ||
| fun set (value : String) : String { |
There was a problem hiding this comment.
I would keep it as a Promise(Never, String) mainly because at some point it will support the async clipboard api.
There was a problem hiding this comment.
Would you like me to go ahead and rewrite to to use that API?
There was a problem hiding this comment.
If you feel like it, that would be great :) In another PR and using this as a fallback (if ('clipboard' in navigator) ...).
gdotdesign
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Clipboard.setmethod clobbers the global state, removing focus from the current active element and removing all content selections. This PR updates the method to remember the initial active element and selection(s), restoring them after the clipboard operation is complete.It also updates
Clipboard.setto return its argument for convenient chaining and removes;which was put at the end of some lines but not others, and isn't necessary.