Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSP] Include CSS and HTML completions #511

Closed
siduck opened this issue Nov 12, 2021 · 4 comments · Fixed by #517
Closed

[LSP] Include CSS and HTML completions #511

siduck opened this issue Nov 12, 2021 · 4 comments · Fixed by #517
Assignees
Labels
feature request tooling Tooling related feature (formatter, documentation, production builder)
Milestone

Comments

@siduck
Copy link

siduck commented Nov 12, 2021

Hi there! been learning mint for a while now and the lsp works very fast and lightweight but I dont get any css and html completions. I could make html , css lsps run on mint filetype tho but those lsps are heavy on my low end machine with just 4gb ram 😞 . I had been working with react recently but while working with react projects my ram almost gets full with all those heavy node stuffs running in the background and Im no longer able to type anything. I found mint which had way lighter lsps and formatters so tried checking it but I miss css , html completions

It would be great to add html , css completions functionalities in mint lsp!

something like these :

image

Css properties and values:

image
image

@siduck siduck changed the title Missing CSS completions Missing CSS, HTML completions Nov 12, 2021
@siduck siduck changed the title Missing CSS, HTML completions Include css , html completions in mint lsp Nov 12, 2021
@Sija
Copy link
Member

Sija commented Nov 12, 2021

I feel your pain, adding those to the mint lsp though seems out of scope IMO.

@Sija Sija added the tooling Tooling related feature (formatter, documentation, production builder) label Nov 12, 2021
@gdotdesign
Copy link
Member

I feel your pain, adding those to the mint lsp though seems out of scope IMO.

Not necessarily, we already have most of the CSS properties in the repository: https://github.com/mint-lang/mint/blob/master/src/assets/css_properties, we can display completions for them only if the cursor is inside a style block.

Adding the values is another matter but not impossible, adding CSS properties and basic HTML tags is a good first step IMO.

@Sija
Copy link
Member

Sija commented Nov 12, 2021

Not necessarily, we already have most of the CSS properties in the repository: https://github.com/mint-lang/mint/blob/master/src/assets/css_properties, we can display completions for them only if the cursor is inside a style block.

That's true, but there's more to completions than the property names. Adding values and the rest would be essentially duplicating LSP server for HTML/CSS - which could be a good topic for a separate, Crystal-based LSP for those languages.

@siduck
Copy link
Author

siduck commented Nov 13, 2021

Not necessarily, we already have most of the CSS properties in the repository: https://github.com/mint-lang/mint/blob/master/src/assets/css_properties, we can display completions for them only if the cursor is inside a style block.

That's true, but there's more to completions than the property names. Adding values and the rest would be essentially duplicating LSP server for HTML/CSS - which could be a good topic for a separate, Crystal-based LSP for those languages.

I think it would still be important since anyone working with mint would obviously using html, css stuff in it and not getting those completions might get frustrating

@gdotdesign gdotdesign self-assigned this Nov 17, 2021
@gdotdesign gdotdesign added this to the 0.15.0 milestone Nov 17, 2021
@Sija Sija changed the title Include css , html completions in mint lsp [LSP] Include CSS and HTML completions Nov 19, 2021
@Sija Sija linked a pull request Nov 19, 2021 that will close this issue
@Sija Sija closed this as completed Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request tooling Tooling related feature (formatter, documentation, production builder)
Development

Successfully merging a pull request may close this issue.

3 participants