Changes for compatability and for accessing Codemirror function from other Mint programs. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…any Mint program.
gdotdesign
reviewed
Sep 25, 2018
|
So, is it merged? |
|
Not yet I just added some comments, to start discussing things. |
|
I agree with all the comments. I’m still getting used to the new language.
…On Tue, Sep 25, 2018 at 4:04 PM Szikszai Gusztáv ***@***.***> wrote:
Not yet I just added some comments, to start discussing things.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACX0xycRGnsnQwAI3BlFSMoE4jLNqrDBks5uefGxgaJpZM4Wva_a>
.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These are the changes I've made in case you want to use them. I'll be adding more to get to more of the CodeMirror API from Mint. But, you can see where I'm going with it.