Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MO-1537 Upgrade moj and govuk frontend versions #2468

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Conversation

zheileman
Copy link
Member

@zheileman zheileman commented Aug 6, 2024

Ticket: https://dsdmoj.atlassian.net/browse/MO-1537

Also update to the latest version of govuk_design_system_formbuilder.

A few deprecation fixes and html markup changes to go along with the new versions.

Most noticeable visual change is probably the new tags look&feel.

Deleted some old Heroku files/references.

@zheileman zheileman changed the title Upgrade moj and govuk frontend versions MO-1537 Upgrade moj and govuk frontend versions Aug 6, 2024
@zheileman zheileman force-pushed the frontend-upgrade branch 2 times, most recently from 23abe40 to 358a038 Compare August 6, 2024 14:09
@zheileman
Copy link
Member Author

zheileman commented Aug 7, 2024

This branch is deployed to test and all looks good to me. Also has had some sanity check from Kallum and Grace.
Old version of the frontend framework is still on staging and preprod for comparison

@zheileman zheileman marked this pull request as ready for review August 7, 2024 10:35
andrewrlee
andrewrlee previously approved these changes Aug 8, 2024
Copy link
Contributor

@andrewrlee andrewrlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ticket: https://dsdmoj.atlassian.net/browse/MO-1537

Also update to the latest version of `govuk_design_system_formbuilder`.

A few deprecation and html markup changes to go along with the new versions.

Deleted some old Heroku files/references.
This let us upgrade to the very latest version of the MoJ frontend that introduces some ES6 syntax that uglifier was not compatible with.
All this is part of the default frontend distribution.
andrewrlee
andrewrlee previously approved these changes Aug 9, 2024
Copy link
Contributor

@andrewrlee andrewrlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is to make tags copy consistent across the board, no longer using all capital letters.
@zheileman zheileman requested review from ryantk and removed request for SebNegahbanMoJ August 13, 2024 07:57
@zheileman zheileman merged commit c7bbfe9 into main Aug 13, 2024
7 checks passed
@zheileman zheileman deleted the frontend-upgrade branch August 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants