ws: Calculate the client IP from the WS request headers as well #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the websocket code adds an IP to X-Forwarded-For where the IP is calculated from the TCP connection established to Console, however the established TCP connection can be coming from the load balancer as well, hence the necesssity to evaluate the client IP based on X-Forwarded-For or X-Real-IP headers Look for client IPs in the websocket request connection.
harshavardhana
approved these changes
Jul 9, 2024
ramondeklein
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the websocket code adds an IP to X-Forwarded-For where the IP is calculated
from the TCP connection established to Console, however the established TCP connection
can be coming from the load balancer as well, hence the necesssity to evaluate the client
IP based on X-Forwarded-For or X-Real-IP headers
Look for client IPs in the websocket request connection.