Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logo as per mineos plans #3383

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Jun 13, 2024

update logo as per mineos plans

Note:
ENTERPRIS-PLUS ENTERPRIS-LITE would show minio eos logos.

ENTERPRIS-PLUS ENTERPRIS-LITE , ENTERPRISE would display Enterprise in License Page.
We do not have UX finalised for this page update.

How does it look:
E.g: EOS
EOS_Log_In

EOS_License_logged_In

E.g: minio
image

image

Build/Test

Checkout this PR
make assets && make install

In case of console static assets build, issues, try web-app/Makefile line 5: replace with the below

@if [ -f "${NVM_DIR}/nvm.sh" ]; then \. "${NVM_DIR}/nvm.sh" && nvm install && nvm use; YARN_CHECKSUM_BEHAVIOR=reset yarn install ; fi && \
and then try make assets && make build

replace console build in mineos or minio accordingly in go.mod file.

replace github.com/minio/console => /home/prakash/MinIO/GIT/go/src/github.com/prakashsvmx/console
Note : Update the replace path as per the local dev setup.

Test MinIO

make build && make install && sudo cp minio /usr/local/bin/minio
CI=true MINIO_ROOT_USER=minio MINIO_ROOT_PASSWORD=minio123 minio server --address ":22000" --console-address ":10000" /tmp/minio-upstream/s1/data{1...4}

Test mineos

checkout mineos repo

make build && make install && sudo cp minio /usr/local/bin/minio-es
 CI=true MINIO_ROOT_USER=minio MINIO_ROOT_PASSWORD=minio123 minio-es server --address ":32000" --console-address ":12000" /tmp/minio-es/s1/data{1...4}

Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested

@harshavardhana harshavardhana merged commit c8a39f9 into minio:master Jun 13, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants