-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storageClass on EditLifecycleModal #3379
Merged
cesnietor
merged 5 commits into
minio:master
from
jinapurapu:fix_edit_ilm_storage_class
Jun 13, 2024
Merged
Fix storageClass on EditLifecycleModal #3379
cesnietor
merged 5 commits into
minio:master
from
jinapurapu:fix_edit_ilm_storage_class
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivaj05
previously approved these changes
Jun 12, 2024
sen-io
approved these changes
Jun 12, 2024
shtripat
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ramondeklein
approved these changes
Jun 13, 2024
bayasdev
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cesnietor
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies correct storage class to lifecycle rule in editLifecycleConfiguration modal.
Also enables editing non-current version storage class and fixes validation for current vs non-current version storage days.
Screen.Recording.2024-06-12.at.12.26.32.PM.mov