-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up minio/pkg to v3 #3349
Bump up minio/pkg to v3 #3349
Conversation
41da8a2
to
e2303ef
Compare
I remember Ramon has a PR (#3353) for below error
|
@donatello PTAL
|
This is because the test is pulling minio master branch and building, but minio also needs the pkg/V3 bump change. This test has a circular dep and can't run for this change. |
why can't it use |
Because master doesn't have pkg/v3 yet. And console does in this pr. So they are kind of incompatible. Both repos need to be updated together and then this test will pass. |
The merge-base changed after approval.
I think silly style of cyclical dependency we must remove. |
@harshavardhana The most effective option would be to merge the console into this repository, but that will probably be a huge task. A less intrusive method would be to try to change - name: Switch to the proper branch
run: |
git checkout "${{ github.head_ref || github.ref_name }}" || echo "Okay, we'll stay on the master branch" You need to make sure the |
yeah @ramondeklein lets try. |
No description provided.