Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 2 new rotation flags in the ocr_predictor #632

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Conversation

charlesmindee
Copy link
Collaborator

This PR adds the 2 flags introduced in #551 in the highest level predictor so the user can easily choose the parameters of the rotation.

Any feedback is welcome!

@charlesmindee charlesmindee self-assigned this Nov 17, 2021
@charlesmindee charlesmindee added type: enhancement Improvement module: models Related to doctr.models labels Nov 17, 2021
@charlesmindee charlesmindee added this to the 0.5.0 milestone Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #632 (1c1a2c3) into main (16d842e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   96.05%   96.07%   +0.02%     
==========================================
  Files         112      112              
  Lines        4359     4357       -2     
==========================================
- Hits         4187     4186       -1     
+ Misses        172      171       -1     
Flag Coverage Δ
unittests 96.07% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/predictor/pytorch.py 100.00% <ø> (ø)
doctr/models/predictor/tensorflow.py 100.00% <ø> (ø)
doctr/models/zoo.py 100.00% <100.00%> (ø)
doctr/models/recognition/crnn/pytorch.py 100.00% <0.00%> (ø)
doctr/datasets/utils.py 94.73% <0.00%> (+2.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d842e...1c1a2c3. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Good idea to document this on the high-level API, I added some doc suggestions

README.md Outdated Show resolved Hide resolved
doctr/models/zoo.py Outdated Show resolved Hide resolved
doctr/models/zoo.py Outdated Show resolved Hide resolved
doctr/models/zoo.py Show resolved Hide resolved
doctr/models/zoo.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
fg-mindee
fg-mindee previously approved these changes Nov 18, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models Related to doctr.models type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants