-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 2 new rotation flags in the ocr_predictor #632
Conversation
Codecov Report
@@ Coverage Diff @@
## main #632 +/- ##
==========================================
+ Coverage 96.05% 96.07% +0.02%
==========================================
Files 112 112
Lines 4359 4357 -2
==========================================
- Hits 4187 4186 -1
+ Misses 172 171 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Good idea to document this on the high-level API, I added some doc suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR adds the 2 flags introduced in #551 in the highest level predictor so the user can easily choose the parameters of the rotation.
Any feedback is welcome!