Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed unused imports and prevents XML attacks #582

Merged
merged 3 commits into from
Nov 4, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • defuses XML attacks
  • removed unused imports

Any feedback is welcome!

@fg-mindee fg-mindee added the type: enhancement Improvement label Nov 4, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Nov 4, 2021
@fg-mindee fg-mindee self-assigned this Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #582 (a4f4a45) into main (c52488c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   96.07%   96.05%   -0.03%     
==========================================
  Files         109      109              
  Lines        4233     4233              
==========================================
- Hits         4067     4066       -1     
- Misses        166      167       +1     
Flag Coverage Δ
unittests 96.05% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/classification/base.py 93.54% <100.00%> (-0.40%) ⬇️
doctr/datasets/detection.py 96.96% <100.00%> (ø)
doctr/io/elements.py 92.09% <100.00%> (+0.09%) ⬆️
doctr/models/recognition/crnn/pytorch.py 100.00% <100.00%> (ø)
doctr/models/recognition/crnn/tensorflow.py 100.00% <100.00%> (ø)
doctr/models/recognition/sar/tensorflow.py 98.49% <100.00%> (ø)
doctr/utils/visualization.py 92.03% <100.00%> (ø)
...dels/detection/differentiable_binarization/base.py 91.19% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c52488c...a4f4a45. Read the comment docs.

@fg-mindee fg-mindee merged commit c882689 into main Nov 4, 2021
@fg-mindee fg-mindee deleted the codacy-improvements branch November 4, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant