Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug in resolve_lines #537

Merged
merged 13 commits into from
Oct 25, 2021
Merged

fix: bug in resolve_lines #537

merged 13 commits into from
Oct 25, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR fixes a bug in resolve_lines, which was not updating the y_center of the lines thus each box of the document was assigned to a new line.
Any feedback is welcome!

@charlesmindee charlesmindee added type: bug Something isn't working module: models Related to doctr.models labels Oct 22, 2021
@charlesmindee charlesmindee added this to the 0.4.1 milestone Oct 22, 2021
@charlesmindee charlesmindee self-assigned this Oct 22, 2021
@fg-mindee
Copy link
Contributor

Would you mind merging main to fix the PyTorch test please? 🙏

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

Perhaps we should create a unittest for a basic word to line aggregation?

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #537 (bff22c9) into main (323d484) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   95.38%   95.36%   -0.03%     
==========================================
  Files         109      109              
  Lines        4182     4182              
==========================================
- Hits         3989     3988       -1     
- Misses        193      194       +1     
Flag Coverage Δ
unittests 95.36% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/builder.py 92.70% <100.00%> (ø)
...dels/detection/differentiable_binarization/base.py 91.19% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 323d484...bff22c9. Read the comment docs.

@charlesmindee
Copy link
Collaborator Author

This is how it looks like now:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models Related to doctr.models type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants