-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bug in resolve_lines #537
Conversation
Would you mind merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
Perhaps we should create a unittest for a basic word to line aggregation?
Codecov Report
@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 95.38% 95.36% -0.03%
==========================================
Files 109 109
Lines 4182 4182
==========================================
- Hits 3989 3988 -1
- Misses 193 194 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR fixes a bug in resolve_lines, which was not updating the y_center of the lines thus each box of the document was assigned to a new line.
Any feedback is welcome!