Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed API template issues with new httpx version #535

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

This fixes the failing CI check.
Any feedback is welcome!

@fg-mindee fg-mindee added type: bug Something isn't working ext: api Related to api folder labels Oct 21, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Oct 21, 2021
@fg-mindee fg-mindee self-assigned this Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #535 (22a4677) into main (3c7303c) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
+ Coverage   95.36%   95.38%   +0.02%     
==========================================
  Files         109      109              
  Lines        4184     4184              
==========================================
+ Hits         3990     3991       +1     
+ Misses        194      193       -1     
Flag Coverage Δ
unittests 95.38% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 91.82% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7303c...22a4677. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fg-mindee fg-mindee merged commit 22e28f7 into main Oct 21, 2021
@fg-mindee fg-mindee deleted the api-fix branch October 21, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: api Related to api folder type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants