Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add crnn_mobilenet small & large ckpts for torch backend #516

Merged
merged 5 commits into from
Sep 30, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR adds both crnn_mobilenet_v3_large and crnn_mobilenet_v3_small pytorch ckpts.

Any feedback is welcome!

@charlesmindee charlesmindee self-assigned this Sep 30, 2021
@charlesmindee charlesmindee added type: enhancement Improvement framework: pytorch Related to PyTorch backend module: models Related to doctr.models topic: text recognition Related to the task of text recognition labels Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #516 (37ab749) into main (14b376e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #516   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files         109      109           
  Lines        4183     4183           
=======================================
  Hits         3990     3990           
  Misses        193      193           
Flag Coverage Δ
unittests 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/crnn/pytorch.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b376e...37ab749. Read the comment docs.

@fg-mindee fg-mindee added this to the 0.4.0 milestone Sep 30, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend module: models Related to doctr.models topic: text recognition Related to the task of text recognition type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants