Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deprecated crnn_resnet31 and sar_vgg16_bn #468

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • deprecated crnn_resnet31 and sar_vgg16_bn and they use combinations of backbones that aren't recommended by their respective paper and do not bring about perf or speed boost.
  • updated documentation accordingly
  • updated unittests accordingly
  • updated demo reco model selection

Any feedback is welcome!

@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation module: models Related to doctr.models ext: tests Related to tests folder type: breaking change Introducing a breaking change ext: demo Related to demo folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text recognition Related to the task of text recognition labels Sep 14, 2021
@fg-mindee fg-mindee added this to the 0.4.0 milestone Sep 14, 2021
@fg-mindee fg-mindee self-assigned this Sep 14, 2021
charlesmindee
charlesmindee previously approved these changes Sep 14, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #468 (7146b25) into main (8fd05b4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   95.77%   95.79%   +0.01%     
==========================================
  Files          95       95              
  Lines        4000     3992       -8     
==========================================
- Hits         3831     3824       -7     
+ Misses        169      168       -1     
Flag Coverage Δ
unittests 95.79% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/crnn/pytorch.py 98.91% <100.00%> (-0.03%) ⬇️
doctr/models/recognition/crnn/tensorflow.py 100.00% <100.00%> (ø)
doctr/models/recognition/sar/pytorch.py 98.34% <100.00%> (-0.03%) ⬇️
doctr/models/recognition/sar/tensorflow.py 98.49% <100.00%> (-0.03%) ⬇️
doctr/models/recognition/zoo.py 100.00% <100.00%> (ø)
...dels/detection/differentiable_binarization/base.py 91.97% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd05b4...7146b25. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fg-mindee fg-mindee merged commit 7377c36 into main Sep 14, 2021
@fg-mindee fg-mindee deleted the reco-deprecation branch September 14, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: demo Related to demo folder ext: tests Related to tests folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models topic: documentation Improvements or additions to documentation topic: text recognition Related to the task of text recognition type: breaking change Introducing a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants