Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed cropping mode in predictor #461

Merged
merged 1 commit into from
Sep 10, 2021
Merged

fix: Fixed cropping mode in predictor #461

merged 1 commit into from
Sep 10, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR fixes the cropping mode when both frameworks are available. #458 introduced an issue occurring for users with both frameworks installed. SInce the priority (default framework mode) is TensorFlow, this PR switches the condition to ensure proper cropping.

Any feedback is welcome!

@fg-mindee fg-mindee added type: bug Something isn't working critical High priority module: models Related to doctr.models framework: tensorflow Related to TensorFlow backend labels Sep 9, 2021
@fg-mindee fg-mindee added this to the 0.4.0 milestone Sep 9, 2021
@fg-mindee fg-mindee self-assigned this Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #461 (0180be4) into main (acb510d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   95.79%   95.82%   +0.02%     
==========================================
  Files          96       96              
  Lines        4023     4023              
==========================================
+ Hits         3854     3855       +1     
+ Misses        169      168       -1     
Flag Coverage Δ
unittests 95.82% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/core.py 93.84% <100.00%> (ø)
...dels/detection/differentiable_binarization/base.py 91.97% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb510d...0180be4. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@charlesmindee charlesmindee merged commit de69819 into main Sep 10, 2021
@charlesmindee charlesmindee deleted the crop-fix branch September 10, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical High priority framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants