Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added CI jobs to check evaluate, collect_env & demo #456

Merged
merged 4 commits into from
Sep 3, 2021

Conversation

fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Sep 3, 2021

Following up on #429, this PR introduces the following modifications:

  • adds a job to run the evaluate.py script on FUNSD
  • adds a job to check the collect_env.py script
  • adds a job to check whether we can run the demo
  • adds an option to run the evaluation script on the first N samples (the CI job checks it for the 10 first samples)

Any feedback is welcome!

@fg-mindee fg-mindee added topic: ci Related to CI ext: scripts Related to scripts folder ext: demo Related to demo folder labels Sep 3, 2021
@fg-mindee fg-mindee added this to the 0.4.0 milestone Sep 3, 2021
@fg-mindee fg-mindee self-assigned this Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #456 (d7227f6) into main (b0d554f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files          96       96           
  Lines        4013     4013           
=======================================
  Hits         3847     3847           
  Misses        166      166           
Flag Coverage Δ
unittests 95.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d554f...d7227f6. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!

@fg-mindee fg-mindee merged commit 64c7864 into main Sep 3, 2021
@fg-mindee fg-mindee deleted the ci-checks branch September 3, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: demo Related to demo folder ext: scripts Related to scripts folder topic: ci Related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants