Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Recognition dataset merging #376

Merged
merged 6 commits into from
Jul 9, 2021
Merged

fix: Recognition dataset merging #376

merged 6 commits into from
Jul 9, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR allows recognition datasets to be merged.
Any feedback is welcome!

@charlesmindee charlesmindee self-assigned this Jul 8, 2021
@charlesmindee charlesmindee added type: enhancement Improvement module: datasets Related to doctr.datasets labels Jul 8, 2021
@charlesmindee charlesmindee added this to the 0.3.1 milestone Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #376 (51a3f4a) into main (b97363c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   96.21%   96.19%   -0.03%     
==========================================
  Files          83       83              
  Lines        3518     3524       +6     
==========================================
+ Hits         3385     3390       +5     
- Misses        133      134       +1     
Flag Coverage Δ
unittests 96.19% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/recognition.py 92.00% <100.00%> (+2.52%) ⬆️
...dels/detection/differentiable_binarization/base.py 91.30% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b97363c...51a3f4a. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 2 comments where I'd like to have your opinion

doctr/datasets/recognition.py Outdated Show resolved Hide resolved
doctr/datasets/recognition.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charlesmindee charlesmindee merged commit 011f934 into main Jul 9, 2021
@charlesmindee charlesmindee deleted the dataset branch July 9, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants