Skip to content

Commit

Permalink
Remove redundant std::move
Browse files Browse the repository at this point in the history
  • Loading branch information
milasudril committed Mar 24, 2021
1 parent 2edeae4 commit adcb3f4
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion alice
Submodule alice updated 1 files
+2 −1 optionruntime.cpp
2 changes: 1 addition & 1 deletion engine/engine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ static String client_name(const String& str)
{
auto ret=str;
ret.append(".anja");
return std::move(ret);
return ret;
}

namespace
Expand Down
4 changes: 2 additions & 2 deletions sessiondata/optionstring.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ String Anja::stringFromOptions(unsigned int option_bits
String ret;

if(*option_names==nullptr)
{return std::move(ret);}
{return ret;}

auto mask=0x1u;

Expand All @@ -28,7 +28,7 @@ String Anja::stringFromOptions(unsigned int option_bits
++option_names;
mask<<=1;
}
return std::move(ret);
return ret;
}

unsigned int Anja::optionsFromString(const char* string
Expand Down
10 changes: 5 additions & 5 deletions sessiondata/session.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ static ArrayDynamicShort<ColorRGBA> color_presets_load(const char* ptr)
{
case '\0':
ret.append(colorFromString(buffer.begin()));
return std::move(ret);
return ret;
case '|':
ret.append(colorFromString(buffer.begin()));
buffer.clear();
Expand All @@ -49,7 +49,7 @@ static ArrayDynamicShort<ColorRGBA> color_presets_load(const char* ptr)

++ptr;
}
return std::move(ret);
return ret;
}

template<class Range>
Expand All @@ -62,7 +62,7 @@ static String string_from_color_presets(const Range& r)
});
ret.append(ColorString(*(r.end()-1)).begin());

return std::move(ret);
return ret;
}


Expand Down Expand Up @@ -180,7 +180,7 @@ ArraySimple<String> Session::channelLabels() const
ret[k]=x.label();
++k;
});
return std::move(ret);
return ret;
}

ArraySimple<ColorRGBA> Session::channelColors() const
Expand All @@ -192,7 +192,7 @@ ArraySimple<ColorRGBA> Session::channelColors() const
ret[k]=x.color();
++k;
});
return std::move(ret);
return ret;
}


Expand Down
8 changes: 4 additions & 4 deletions ui/waveformeditor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ ArraySimple<float> WaveformEditor::mean_square(const float* begin,const float* e
m_progress_null.reset(new Dialog<ProgressBar,DialogNull>(m_box,"Anja: Computing signal levels"));
ms.compute(begin,vals_ms.begin(),end - begin,*this);
m_progress_null.reset();
return std::move(vals_ms);
return vals_ms;
}

static ArraySimple<float> decimate(const ArraySimple<float>& src,double dt)
Expand All @@ -175,7 +175,7 @@ static ArraySimple<float> decimate(const ArraySimple<float>& src,double dt)
val=src[pos];
++k;
});
return std::move(ret);
return ret;
}

static void plot_append(const float* begin,const float* end,double dt,XYPlot& plot)
Expand Down Expand Up @@ -206,15 +206,15 @@ ArraySimple<float> WaveformEditor::filename_update(const WaveformProxy& waveform
{return std::max(powerToDb(x),-145.0f);});

plot_append(ms.begin(),ms.end(),0.5e-3,plot.curvesRemove());
return std::move(ms);
return ms;
}
else
{
ArraySimple<float> ret(2);
ret[0]=-145.0f;
ret[1]=-145.0f;
plot.curvesRemove();
return std::move(ret);
return ret;
}
}

Expand Down

0 comments on commit adcb3f4

Please sign in to comment.