Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix CI and drop support for Node 12 #3

Merged
merged 5 commits into from
Dec 8, 2022
Merged

[WIP] Fix CI and drop support for Node 12 #3

merged 5 commits into from
Dec 8, 2022

Conversation

mikrostew
Copy link
Owner

@mikrostew mikrostew commented Nov 30, 2022

Fix CI for this repo, which has been failing for the last few months.

Updated Node LTS Versions

This drops support for Node 12.x (which is EOL as of 2022/04/30).

The tests now run against 14.x and 16.x.

I had to update workerpool to pull in the fix for Node16 mentioned in this issue.

And I updated to a more recent version of Yarn.

Legacy Mocha Tests

These have been failing for a while, with this error:

Error: Unable to require module 'crypto' because it was not in the whitelist.

So I added that to fastbootDependencies, which fixed the issue.

Running with Node 16 surfaced a new error with starting the server in the tests, so I removed the skipNpm: true option to fix that.

Ember-Try Tests

These have also been failing for a while, with this error:

Build Error (broccoli-persistent-filter:Babel > [Babel: @ember/test-helpers]) in @ember/test-helpers/-internal/build-registry.js

[BABEL]: Cannot find module 'babel-plugin-dynamic-import-node/utils'

I fixed that by preventing ember-try from running with --no-lockfile (which it does by default, and was causing a dependency mismatch when running the tests).

@mikrostew mikrostew changed the title Fix CI and drop support for Node 12 [WIP] Fix CI and drop support for Node 12 Dec 1, 2022
@mikrostew mikrostew merged commit c02722b into master Dec 8, 2022
@mikrostew mikrostew deleted the fix-ci branch December 8, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant