fix: improve settings descriptions for actions triggered on save #230052
Conversation
|
@microsoft-github-policy-service agree |
elias-pap
force-pushed
the
improve-settings-descriptions
branch
from
5943ca9
to
22bef86
Compare
There was a problem hiding this comment.
Please also take a look at editor.codeActions.triggerOnFocusChange, which will save in certain scenarios:
- auto save is
afterDelay - editor code actions on save are set to
always. - focus is changed
note that this only works atm for editor code actions on save, and not notebooks.
| @@ -64,7 +64,7 @@ const codeActionsOnSaveSchema: IConfigurationPropertySchema = { | |||
| items: { type: 'string' } | |||
| } | |||
| ], | |||
| markdownDescription: nls.localize('editor.codeActionsOnSave', 'Run Code Actions for the editor on save. Code Actions must be specified and the editor must not be shutting down. Example: `"source.organizeImports": "explicit" `'), | |||
| markdownDescription: nls.localize('editor.codeActionsOnSave', 'Run Code Actions for the editor on save. Code Actions must be specified and the editor must not be shutting down. When [auto save](https://code.visualstudio.com/docs/editor/codebasics#_save-auto-save) is set to `afterDelay`, Code Actions will run when the file is saved explicitly, not when saved automatically. Example: `"source.organizeImports": "explicit" `'), | |||
There was a problem hiding this comment.
for this and all cases below, instead of pointing towards documentation, please point it towards the auto save setting
There was a problem hiding this comment.
nit: change to ....will only be run when the file is saved explicitly.
elias-pap
changed the title
elias-pap
force-pushed
the
improve-settings-descriptions
branch
from
22bef86
to
2de9ac0
Compare
Not sure what you mean. This setting does not "save" in certain scenarios, it only triggers the code actions under some conditions, one of them being |
closes #230051