Fix all x-model highlight flickering #224415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #224321
With the new parameter inside the wordHighlighter's
run()andstopAll()fxns, we can preserve decorations on models as we respond to new highlight requests from different events.No more flickering on settings change, due to only driving new worker requests from a single editor, and also preserving highlights upon changing between single and multifile highlight settings.
Also a new delayer to avoid running a highlight req for both editor focus and cursor position changes. Previously, this would occur when switching back to a previously focused window, and also putting a cursor in a new position. This would trigger an editor focus event, and then immediately trigger a cursor change event. Now, only 1
run()will be triggered. This also preserves the fix for the issue where you click back into the EXACT SAME cursor position into a previous tab. Rare, but it happens.