Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: adopt feedback for call stack api #224308

Merged
merged 1 commit into from
Jul 30, 2024
Merged

testing: adopt feedback for call stack api #224308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/api/common/extHostTypeConverters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1891,7 +1891,7 @@ export namespace TestMessage {
stackTrace: (message as vscode.TestMessage2).stackTrace?.map(s => ({
label: s.label,
position: s.position && Position.from(s.position),
uri: s.file && URI.revive(s.file).toJSON(),
uri: s.uri && URI.revive(s.uri).toJSON(),
})),
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/api/common/extHostTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4107,7 +4107,7 @@ export class TestMessageStackFrame {
*/
constructor(
public label: string,
public file?: vscode.Uri,
public uri?: vscode.Uri,
public position?: Position,
) { }
}
Expand Down
4 changes: 2 additions & 2 deletions src/vscode-dts/vscode.proposed.testMessageStackTrace.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ declare module 'vscode' {
* The location of this stack frame. This should be provided as a URI if the
* location of the call frame can be accessed by the editor.
*/
file?: Uri;
uri?: Uri;

/**
* Position of the stack frame within the file.
Expand All @@ -33,6 +33,6 @@ declare module 'vscode' {
* @param file The file URI of the stack frame
* @param position The position of the stack frame within the file
*/
constructor(label: string, file?: Uri, position?: Position);
constructor(label: string, uri?: Uri, position?: Position);
}
}
Loading