Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve highlights switching between single/multi file highlights #224243

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Preserve highlights switching between single/multi file highlights #224243

merged 4 commits into from
Jul 30, 2024

Conversation

Yoyokrazy
Copy link
Contributor

Fixes: #196356

@Yoyokrazy
Copy link
Contributor Author

Yoyokrazy commented Jul 29, 2024 •
edited
Loading

todo:
- [ ] one setting change triggers configuration change event firings per visible editor, causing a _run() ==> _stopAll() sequence if singleFile or multiFile. creates a flicker. Fix/eliminate this second firing

putting the flicker fix into a different issue. may require a more thorough refactoring

@Yoyokrazy Yoyokrazy self-assigned this Jul 29, 2024
@Yoyokrazy Yoyokrazy added the editor-highlight Editor selection/word highlight issues label Jul 29, 2024
@Yoyokrazy Yoyokrazy marked this pull request as ready for review July 30, 2024 17:31
@vscodenpa vscodenpa added this to the August 2024 milestone Jul 30, 2024
@Yoyokrazy Yoyokrazy mentioned this pull request Jul 30, 2024
Closed
@Yoyokrazy Yoyokrazy enabled auto-merge (squash) July 30, 2024 17:51
@Yoyokrazy Yoyokrazy disabled auto-merge July 30, 2024 18:15
@Yoyokrazy Yoyokrazy enabled auto-merge (squash) July 30, 2024 18:31
@Yoyokrazy Yoyokrazy requested a review from bhavyaus July 30, 2024 18:31
@Yoyokrazy Yoyokrazy disabled auto-merge July 30, 2024 18:32
@Yoyokrazy Yoyokrazy enabled auto-merge (squash) July 30, 2024 18:36
@Yoyokrazy Yoyokrazy merged commit 26c86b8 into main Jul 30, 2024
6 checks passed
@Yoyokrazy Yoyokrazy deleted the milively/highlight-debt branch July 30, 2024 18:54
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bhavyaus bhavyaus bhavyaus approved these changes

Assignees

@Yoyokrazy Yoyokrazy

Labels
editor-highlight Editor selection/word highlight issues
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.

Settings change does not preserve highlights on the recently interacted model
3 participants
@Yoyokrazy @bhavyaus @vscodenpa