Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup web html pages #216609

Merged
merged 2 commits into from
Aug 28, 2024
Merged

cleanup web html pages #216609

merged 2 commits into from
Aug 28, 2024

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Jun 19, 2024

This reduces the number of HTML files shipped as part of our web from:

/out/vs/code/browser/workbench/callback.html
/out/vs/code/browser/workbench/workbench-dev.html
/out/vs/code/browser/workbench/workbench.html
/out/vs/workbench/contrib/webview/browser/pre/fake.html
/out/vs/workbench/contrib/webview/browser/pre/index-no-csp.html
/out/vs/workbench/contrib/webview/browser/pre/index.html
/out/vs/workbench/services/extensions/worker/webWorkerExtensionHostIframe.html
/extensions/github-authentication/media/index.html
/extensions/microsoft-authentication/media/index.html

to:

/out/vs/workbench/contrib/webview/browser/pre/fake.html
/out/vs/workbench/contrib/webview/browser/pre/index-no-csp.html
/out/vs/workbench/contrib/webview/browser/pre/index.html
/out/vs/workbench/services/extensions/worker/webWorkerExtensionHostIframe.html

@joaomoreno joaomoreno self-assigned this Jun 19, 2024
@joaomoreno joaomoreno added this to the June 2024 milestone Jun 19, 2024
@bpasero
Copy link
Member

bpasero commented Jun 20, 2024

🤔 what about when we serve the web UI from a tunnel as part of our server? Don't we have to ship at least workbench.html and thus callback.html too?

@joaomoreno
Copy link
Member Author

Thanks for taking a look. This PR only affects the web build, which we happen to (1) push to builds.code.visualstudio.com and (2) publish to CDN. It doesn't affect our server+web combo. Does that make sense?

@bpasero
Copy link
Member

bpasero commented Jun 20, 2024

Ah ok, thanks for clarifying.

@joaomoreno joaomoreno modified the milestones: June 2024, July 2024 Jun 27, 2024
@joaomoreno joaomoreno marked this pull request as ready for review June 27, 2024 10:06
@hediet hediet modified the milestones: July 2024, August 2024 Jul 26, 2024
@joaomoreno joaomoreno merged commit 54cad31 into main Aug 28, 2024
6 checks passed
@joaomoreno joaomoreno deleted the joao/tan-beetle branch August 28, 2024 08:12
joaomoreno added a commit that referenced this pull request Aug 28, 2024
@joaomoreno joaomoreno restored the joao/tan-beetle branch August 28, 2024 12:25
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants