fix: setting labels appearing in widgets #213826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
May 29, 2024
Comment on lines
+902
to
903
| label: '', | ||
| tooltip: this.getLocalizedStrings().editActionTooltip, |
There was a problem hiding this comment.
Don't you need a label for a11y reasons?
There was a problem hiding this comment.
There is an icon for the button and a tooltip
Supplying a label overrides the icon
There was a problem hiding this comment.
Does a screen reader read the tooltip when it's tabbed to? If it just reads the icon, chances are this is a bad experience
|
Here's how the button looks with this PR. Please check #213717 for how the buttons look in Insiders. |
Tyriar
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213717