Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM - all calls from extHostSCM to mainThreadSCM should use a sequencer to ensure that the source control object is created #213792

Merged
merged 1 commit into from
May 29, 2024
Merged

SCM - all calls from extHostSCM to mainThreadSCM should use a sequencer to ensure that the source control object is created #213792

merged 1 commit into from
May 29, 2024

Conversation

lszomoru
Copy link
Member

Fixes #212857

@lszomoru
SCM - all calls from extHostSCM to mainThreadSCM should use a sequenc…
b467626 
…er to ensure that the source control object is created
@lszomoru lszomoru self-assigned this May 29, 2024
@lszomoru lszomoru enabled auto-merge (squash) May 29, 2024 10:25
@lszomoru lszomoru added this to the May 2024 milestone May 29, 2024
@lszomoru lszomoru added the scm General SCM compound issues label May 29, 2024
@lszomoru lszomoru merged commit 24dd222 into main May 29, 2024
7 checks passed
@lszomoru lszomoru deleted the lszomoru/accessible-catfish branch May 29, 2024 10:41
lszomoru added a commit that referenced this pull request May 31, 2024
@lszomoru
Revert "SCM - all calls from extHostSCM to mainThreadSCM should use a…
63ecce7 
… sequencer to ensure that the source control object is created (#213792)"

This reverts commit 24dd222.
IOLOII
IOLOII reviewed Jun 3, 2024
View reviewed changes
Copy link

@IOLOII IOLOII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

lszomoru added a commit that referenced this pull request Jun 4, 2024
@lszomoru
SCM - 💄 remove the use of a sequencer (#213997)
3aba040 
* Revert "SCM - all calls from extHostSCM to mainThreadSCM should use a sequencer to ensure that the source control object is created (#213792)"

This reverts commit 24dd222.

* Initial implementation

* Pull request feedback

* Revert unnecessary change

* Use map of barriers instead

* 💄 rename
@microsoft microsoft locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IOLOII IOLOII IOLOII left review comments

@jrieken jrieken jrieken approved these changes

Assignees

@lszomoru lszomoru

Labels
scm General SCM compound issues
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.

Gutter indicators not working after updating to 1.90.0-insiders
3 participants
@lszomoru @jrieken @IOLOII