Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase listener refusal threshold significantly #213292

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented May 23, 2024

No description provided.

@jrieken jrieken self-assigned this May 23, 2024
@jrieken jrieken enabled auto-merge (squash) May 23, 2024 06:48
@vscodenpa vscodenpa added this to the May 2024 milestone May 23, 2024
bpasero
bpasero previously approved these changes May 23, 2024
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , this means we can probably remove some / all of the custom overrides.

@jrieken
Copy link
Member Author

jrieken commented May 23, 2024

👍 , this means we can probably remove some / all of the custom overrides.

I don't think so. We still emit warnings and report errors for potential listener leaks but this PR means listener refusal (the last resort before freezing) happens much later

@jrieken jrieken merged commit d42d42e into main May 23, 2024
6 checks passed
@jrieken jrieken deleted the joh/cuddly-cicada branch May 23, 2024 09:07
andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this pull request May 26, 2024
* increase listener refusal threshold significantly

* fix tests
@microsoft microsoft locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants