Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tree view show hover #213212

Merged
merged 1 commit into from
May 23, 2024
Merged

Remove tree view show hover #213212

merged 1 commit into from
May 23, 2024

Conversation

benibenj
Copy link
Contributor

I removed the Show Tree Hover command and all it's dependencies as list.showHover is able to provide a better experience now.

Pressing Ctrl+K | Ctrl+i shows the hover of the item and sets focus on it. The user can then press any key (except Tab) to close the hover which will move focus back to the tree element.

@benibenj benibenj requested a review from alexr00 May 22, 2024 08:12
@benibenj benibenj self-assigned this May 22, 2024
@benibenj benibenj enabled auto-merge (squash) May 22, 2024 08:12
@vscodenpa vscodenpa added this to the May 2024 milestone May 22, 2024
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@benibenj benibenj merged commit 082435c into main May 23, 2024
7 checks passed
@benibenj benibenj deleted the benibenj/maximum-ostrich branch May 23, 2024 08:08
andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this pull request May 26, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants