Benibenj/registerContextKeyHandler #213135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
benibenj
commented
May 21, 2024
bpasero
requested changes
May 22, 2024
bpasero
requested changes
May 22, 2024
|
Btw there are unit test failures, and I wonder: can we add unit tests for this? |
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
|
Looking into adding tests... |
bpasero
requested changes
May 23, 2024
bpasero
requested changes
May 23, 2024
There was a problem hiding this comment.
I still feel something is off and in my testing I find bugs, around the "Open Changes" action.
When I make changes to an editor, the action should appear, but it does not. And when it is there, I see it on other editors too.
Can you do a smoke test to see if this behaves correctly? I feel this is around the fact that we do not listen to active editor changes for registered context keys unless a group is added.
|
Added test that fails with this bug and fixed the bug. |
bpasero
approved these changes
May 23, 2024
andremmsilva
pushed a commit
to PIC1G55/vscodeG55
that referenced
this pull request
May 26, 2024
* cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup * first draft contexkt key registration * Make it a provider * Use group instead of active editor * getGroupContextKeyValue * doc * Fix merge error * 💄 --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to register a context key provider to set the context keys for each editor group context and the global one