feat: allow ➡️ to add chat context in background #213078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
reviewed
May 20, 2024
| override async run(accessor: ServicesAccessor, ...args: any[]): Promise<void> { | ||
| const quickInputService = accessor.get(IQuickInputService); | ||
| const chatVariablesService = accessor.get(IChatVariablesService); | ||
| const widgetService = accessor.get(IChatWidgetService); | ||
| const context: { widget?: IChatWidget } | undefined = args[0]; |
There was a problem hiding this comment.
could args be undefined here, thus this would throw?
meganrogge
approved these changes
May 20, 2024
roblourens
reviewed
May 20, 2024
| @@ -54,7 +60,7 @@ export interface IQuickAccessOptions { | |||
| /** | |||
| * Provider specific options for this particular showing of the | |||
| * quick access. | |||
| */ | |||
| */ | |||
| @@ -326,6 +326,14 @@ export abstract class PickerQuickAccessProvider<T extends IPickerQuickAccessItem | |||
|
|
|||
| // Accept the pick on accept and hide picker | |||
| disposables.add(picker.onDidAccept(event => { | |||
| if (runOptions?.handleAccept) { | |||
There was a problem hiding this comment.
Can't you use the 'accept' callback on the item to do the same thing? I don't follow
There was a problem hiding this comment.
As the consumer of the quick access from chat context action land, we don't control the items in the picker, they are populated from the anything quick access in this case
There was a problem hiding this comment.
We could overwrite the accept handler for all items in the anything quick access layer, but this feels more explicit
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
May 22, 2024
andremmsilva
pushed a commit
to PIC1G55/vscodeG55
that referenced
this pull request
May 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @TylerLeonhardt