Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove brackets from comments, strings and regexes before evaluating the indentation #210641

Merged
merged 50 commits into from
May 27, 2024
Merged

Remove brackets from comments, strings and regexes before evaluating the indentation #210641

merged 50 commits into from
May 27, 2024

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Apr 18, 2024 •
edited
Loading

fixes #209862

I have made an attempt to combine the methods of the indentation.test.ts and autoindent.test.ts files, but this caused the following error: uncaught ReferenceError: window is not defined. I suppose this is because the autoindent.test.ts file contains node.js tests which were accessing methods from the non node.js tests in indentation.test.ts.

@aiday-mar aiday-mar self-assigned this Apr 18, 2024
@aiday-mar
polishing the code
3313082
@aiday-mar
adding code
cc8ea28
@aiday-mar
adding the language
42e9b12
@aiday-mar
reshuffling the code to avoid cyclic dependency
31bab16
@aiday-mar
polihsing code
5f15946
@aiday-mar
uncommenting tests
3b93b8e
@aiday-mar
also adopting the indentation rules within the reindentation operation
c5335b7
@aiday-mar
using instead the sliced line tokens instead of the scoped line tokens
50bb21f
@aiday-mar
polishing the code
4c178cf
@aiday-mar
using start indices instead
958a760
@aiday-mar
using value everywhere
50fc183
@aiday-mar
using the token data to type the tokens
8b350c5
@aiday-mar
setting to number instead of standard token type
f43cb1a
@aiday-mar
using token data from autoindenttest.ts
8f3a9ee
@aiday-mar
using same code in both test files
7f4ac61
@aiday-mar
placing instantiation service into the registerLanguage method
f871d5b
@aiday-mar
Merge branch 'main' into near-bandicoot
39e12d0
@aiday-mar
copying object into the node js autoindent.ts
1113593
@aiday-mar aiday-mar requested a review from hediet April 19, 2024 14:39
@aiday-mar aiday-mar marked this pull request as ready for review April 19, 2024 14:39
@aiday-mar aiday-mar enabled auto-merge (squash) April 19, 2024 14:40
@vscodenpa vscodenpa added this to the April 2024 milestone Apr 19, 2024
@aiday-mar aiday-mar modified the milestones: April 2024, May 2024 Apr 24, 2024
@aiday-mar
polishing the code
5593039
@aiday-mar
polishing the code
48122ba
@aiday-mar
removing the 1 from the end character offset calculations
da798e6
@aiday-mar
Merge branch 'main' into near-bandicoot
a447a1f
@aiday-mar
fixing compile errors
86f1fae
@aiday-mar
removing the changes to the autoindent.test.ts file, this will be don…
feb1a31 
…e in a separate PR
@aiday-mar
Merge branch 'main' into near-bandicoot
1dd7b59
@aiday-mar
adding tokenization support into the test
8770945
@aiday-mar
adding code in order to include the modified line tokens
0ddda76
@aiday-mar
disposing the language service in the tests
058f92c
@aiday-mar
reverting the language service changes and adding the languageIdCodec…
d5a9fb8 
… into the IViewLineTokens interface
@aiday-mar
polishing further the code
33534aa
@aiday-mar
using tokens directly and not using the method on the scopedLineToken…
4ee9475 
…s class
@aiday-mar
extracting the virtual model creation into a separate function
353b7f7
@aiday-mar
creating a static constructor directly on the line tokens
33d93f0
@aiday-mar
adding regexp directly into the bracket configuration
623d169
@aiday-mar
polishing the code
f184552
@aiday-mar
adding the global flag on the regex
903ddf2
@aiday-mar
adding the text
4d74953
@aiday-mar
polishing the code and adding test for the indentation context processor
01e76d6
@aiday-mar
adding tests
b143fda
@aiday-mar aiday-mar merged commit d309e11 into main May 27, 2024
6 checks passed
@aiday-mar aiday-mar deleted the near-bandicoot branch May 27, 2024 09:18
@aiday-mar aiday-mar mentioned this pull request May 27, 2024
Closed
@microsoft microsoft locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hediet hediet hediet approved these changes

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.

Explore removing brackets of language configuration file from the string/regex before evaluating indentation
3 participants
@aiday-mar @hediet @vscodenpa