Hook up prototype paste with imports for JS/TS #204665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For microsoft/TypeScript#57262 but with proposed changes to ts protocol
navya9singh
reviewed
Feb 9, 2024
| arguments: GetPostPasteImportFixesRequestArgs; | ||
| } | ||
| export type DocumentRange = FileRangeRequestArgs; | ||
| export type CopyRange = { |
There was a problem hiding this comment.
Updated the protocol. I believe we can remove the CopyRange and DocumentRange here now since FileSpan extends TextSpan, so we can get the start and end locations from there.
There was a problem hiding this comment.
I've updated the pull request @mjbvz microsoft/TypeScript#57262
mjbvz
commented
Mar 5, 2024
| return; | ||
| } | ||
|
|
||
| const edit = new vscode.DocumentPasteEdit('', vscode.l10n.t("Paste with imports")); |
There was a problem hiding this comment.
This name should like come from TS
lszomoru
approved these changes
May 24, 2024
andremmsilva
pushed a commit
to PIC1G55/vscodeG55
that referenced
this pull request
May 26, 2024
* Hook up prototype paste with imports for JS/TS For microsoft/TypeScript#57262 but with proposed changes to ts protocol * Support new api * Update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft/TypeScript#57262 but with proposed changes to ts protocol
cc @navya9singh