Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust scroll behavior when elements resize #193530

Closed
wants to merge 12 commits into from
Closed

Adjust scroll behavior when elements resize #193530

wants to merge 12 commits into from

Commits on Sep 19, 2023

  1. dont let an element shrink itself entirely out of view

    @amunger
    amunger committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    18505d5 View commit details
    Browse the repository at this point in the history

  2. skip test for old behavior

    @amunger
    amunger committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2585032 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. comment

    @amunger
    amunger committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    596d2b2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into aamunger/scrollOnResize

    @amunger
    amunger authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8d93043 View commit details
    Browse the repository at this point in the history

  3. calculate distance to show last line

    @amunger
    amunger committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fc2c860 View commit details
    Browse the repository at this point in the history

  4. test for new behavior

    @amunger
    amunger committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d98f7f8 View commit details
    Browse the repository at this point in the history

  5. make sure not to pass a negative number

    @amunger
    amunger committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    564b0cf View commit details
    Browse the repository at this point in the history

  6. move check to listView

    @amunger
    amunger committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d68a256 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. keep scrolltop adjustement for resizing within listView

    @amunger
    amunger committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    414796d View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Merge branch 'main' into aamunger/scrollOnResize

    @amunger
    amunger authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f1245d2 View commit details
    Browse the repository at this point in the history

  2. one scroll option, or the other

    @amunger
    amunger committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    51eec6f View commit details
    Browse the repository at this point in the history

  3. move scroll anchor logic into users of updateElementHeight

    @amunger
    amunger committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    ce5dda9 View commit details
    Browse the repository at this point in the history