Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and adopt edit session identifier API proposal #157733

Merged
merged 22 commits into from
Aug 19, 2022
Merged

Implement and adopt edit session identifier API proposal #157733

merged 22 commits into from
Aug 19, 2022

Conversation

joyceerhl
Copy link
Contributor

@joyceerhl joyceerhl commented Aug 10, 2022 •
edited
Loading

@joyceerhl joyceerhl self-assigned this Aug 10, 2022
@joyceerhl joyceerhl mentioned this pull request Aug 10, 2022
Open
@joyceerhl joyceerhl force-pushed the dev/joyceerhl/beautiful-crayfish branch from 4682d7c to 20739de Compare August 10, 2022 06:44
@joyceerhl joyceerhl force-pushed the dev/joyceerhl/beautiful-crayfish branch from 20739de to 436e4b4 Compare August 11, 2022 05:09
@joyceerhl
* Create a separate service
af4d7cf 
* Accept WorkspaceFolder instead of URI
* Return string instead of object
@joyceerhl
Merge branch 'main' of https://github.com/microsoft/vscode into dev/j…
7b76b49 
…oyceerhl/beautiful-crayfish
@joyceerhl
Make edit session restores resilient to provider registration races
8e4ebf9 
* Introduce an activation event
* Activate contributing extension before using provider
@joyceerhl
CanonicalWorkspaceIdentity -> EditSessionIdentity
db4fff1
@joyceerhl
Show progress while resuming edit session
e6257cf
@joyceerhl joyceerhl changed the title Implement and adopt canonical workspace identifier API proposal Implement and adopt edit session identifier API proposal Aug 15, 2022
jrieken
jrieken reviewed Aug 16, 2022
View reviewed changes
src/vs/workbench/api/common/extHost.api.impl.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHostWorkspace.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHostWorkspace.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHostWorkspace.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHostWorkspace.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHostWorkspace.ts Outdated Show resolved Hide resolved
@joyceerhl joyceerhl added this to the August 2022 milestone Aug 16, 2022
@joyceerhl joyceerhl force-pushed the dev/joyceerhl/beautiful-crayfish branch from 56c125e to c4146fd Compare August 17, 2022 04:28
bpasero
bpasero previously approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only glanced high level over it.

src/vs/platform/workspace/common/editSessions.ts Show resolved Hide resolved
@joyceerhl joyceerhl linked an issue Aug 17, 2022 that may be closed by this pull request
API: Edit session identifier provider #157734
Open
@joyceerhl joyceerhl mentioned this pull request Aug 17, 2022
Closed
@joyceerhl joyceerhl removed a link to an issue Aug 18, 2022
API: Edit session identifier provider #157734
Open
@joyceerhl joyceerhl linked an issue Aug 18, 2022 that may be closed by this pull request
Support Continue Working On with edit session in desktop #156833
Closed
@joyceerhl joyceerhl marked this pull request as ready for review August 18, 2022 17:37
@joyceerhl joyceerhl enabled auto-merge (squash) August 19, 2022 03:22
joaomoreno
joaomoreno approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the git extension side of things.

FYI @lszomoru: @joyceerhl has asked me to review this in time for endgame testing, given you are OOF right now.

jrieken
jrieken approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API wiring looks good

src/vs/workbench/api/browser/mainThreadWorkspace.ts Show resolved Hide resolved
@joyceerhl joyceerhl merged commit fa4ff15 into main Aug 19, 2022
@joyceerhl joyceerhl deleted the dev/joyceerhl/beautiful-crayfish branch August 19, 2022 15:01
@joyceerhl joyceerhl mentioned this pull request Aug 19, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

@jrieken jrieken jrieken approved these changes

@bpasero bpasero bpasero left review comments

@lszomoru lszomoru Awaiting requested review from lszomoru

Assignees

@joyceerhl joyceerhl

Labels
None yet
Projects
None yet
Milestone
August 2022
Development

Successfully merging this pull request may close these issues.

Support Continue Working On with edit session in desktop
4 participants
@joyceerhl @joaomoreno @bpasero @jrieken